Re: [PATCH 06/13] DMAENGINE: driver for the ARM PL080/PL081 PrimeCells

[Jassi Brar]

On Thu, Dec 23, 2010 at 5:17 PM, Linus Walleij
<linus.ml.walleij@xxxxxxxxx> wrote:
> 2010/12/23 Dan Williams <dan.j.williams@xxxxxxxxx>:
>> On Wed, Dec 22, 2010 at 4:29 AM, Russell King - ARM Linux
>> <linux@xxxxxxxxxxxxxxxx> wrote:
>>> As described above in my code analysis, pl08x_tasklet takes the spinlock,
>>> calls pl011_dma_tx_callback and eventually back to pl08x_prep_slave_sg
>>> and pl08x_prep_channel_resources which then try to take the spinlock
>>> again, leading to deadlock.
>>
>> This is listed in the dmaengine documentation [1], but I obviously
>> missed this before merging. ÂThis also would have been caught by
>> lockdep as required by SubmitChecklist.
>
> Yeah, my bad. I'll get better at this... :-(
> (I blame it partially on inaccessible hardware, sob sob. I do like to
> run lockdep.)
>
>>ÂIt looks like this driver needs a full scrub
>> which seems unreasonable to complete and test over the holidays before
>> .37 lands. ÂLinus we either need to mark this "depends on BROKEN" or
>> revert it.
>
> Isn't it really as simple as to release the spinlock during callbacks?
> That lock is only intended to protect the plchan variables, not to block
> anyone from queueing new stuff during the callback (as happens now).
>
> It can release that lock, make a callback where a new descriptor
> gets queued, and then take it again and start looking at the queue,
> at which point it discovers the new desc and process it.
>
> So something like this:
>
>
> From: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> Date: Thu, 23 Dec 2010 09:06:14 +0100
> Subject: [PATCH] dma: release pl08x channel lock during callback
>
> The spinlock is not really safeguarding any resources during the
> callback, so let's release it before that and take it back
> afterwards so as to avoid deadlocks.
>
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>
> ---
> Âdrivers/dma/amba-pl08x.c | Â Â7 +++++--
> Â1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index b605cc9..7879a22 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -1651,8 +1651,11 @@ static void pl08x_tasklet(unsigned long data)
> Â Â Â Â Â Â Â Â/*
> Â Â Â Â Â Â Â Â * Callback to signal completion
> Â Â Â Â Â Â Â Â */
> - Â Â Â Â Â Â Â if (callback)
> - Â Â Â Â Â Â Â Â Â Â Â callback(callback_param);
> + Â Â Â Â Â Â Â if (callback) {
> + Â Â Â Â Â Â Â Â Â Â Â Âspin_unlock(&plchan->lock);
> + Â Â Â Â Â Â Â Â Â Â Â Âcallback(callback_param);
> + Â Â Â Â Â Â Â Â Â Â Â Âspin_lock(&plchan->lock);
> + Â Â Â Â Â Â Â Â}
How about adding completed requests to a list and go on to do important
channel management stuff, and do callbacks at the end after dropping the lock.
As in pl330_tasklet of drivers/dma/pl330.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/