Re: [PATCH] tcp: cleanup of cwnd initialization intcp_init_metrics()

[Jiri Kosina]

On Thu, 23 Dec 2010, Eric Dumazet wrote:

> Le mercredi 22 dÃcembre 2010 Ã 19:39 +0100, Jiri Kosina a Ãcrit :
> > Commit 86bcebafc5e7f5 ("tcp: fix >2 iw selection") fixed a case when 
> > congestion window initialization has been mistakenly omitted by 
> > introducing cwnd label and putting backwards jump from the end of the 
> > function.
> > 
> > This makes the code unnecessarily tricky to read and understand on a first 
> > sight.
> > 
> > Shuffle the code around a little bit to make it more obvious.
> 
> Well in fine you have
> 
> 	if (inet_csk(sk)->icsk_rto < TCP_TIMEOUT_INIT && !tp->rx_opt.saw_tstamp)
> 		goto reset;
> 	goto out;
> reset:
> 
> Is that really more obvious ? ;)

To me it seems much more obvious than goto from the very end of the 
function somewhere into the middle and returning from there, but 
definitely a matter of personal taste.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/