Re: [PATCH] arch/x86/oprofile/op_model_amd.c: perform initialisationon a single CPU

From: Ingo Molnar
Date: Mon Jan 03 2011 - 07:04:14 EST



* Robert Richter <robert.richter@xxxxxxx> wrote:

> static void init_ibs(void)
> {
> ibs_caps = get_ibs_caps();

this get_ibs_caps() call is percpu too - still it now runs with preempt off.

> + printk(KERN_INFO "oprofile: AMD IBS detected (0x%08x)\n",
> + (unsigned)ibs_caps);

that cast looks ugly and unnecessary.

I fixed both in the commit below. (not tested yet)

Thanks,

Ingo

--------------->