Re: [PATCH] writeback: avoid unnecessary determine_dirtyable_memorycall

[David Rientjes]

On Tue, 4 Jan 2011, Minchan Kim wrote:

> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index fc93802..c340536 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -390,9 +390,12 @@ void global_dirty_limits(unsigned long *pbackground, unsigned long *pdirty)
>  {
>  	unsigned long background;
>  	unsigned long dirty;
> -	unsigned long available_memory = determine_dirtyable_memory();
> +	unsigned long available_memory;

You need unsigned long uninitialized_var(available_memory) to avoid the 
warning.

>  	struct task_struct *tsk;
>  
> +	if (!vm_dirty_bytes || !dirty_background_bytes)
> +		available_memory = determine_dirtyable_memory();
> +
>  	if (vm_dirty_bytes)
>  		dirty = DIV_ROUND_UP(vm_dirty_bytes, PAGE_SIZE);
>  	else
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/