Re: [PATCH 6/7] perf: Use MSR names in the extra reg lists

[Peter Zijlstra]

On Mon, 2010-12-27 at 23:38 +0800, Lin Ming wrote:
> @@ -88,7 +88,8 @@ static struct event_constraint intel_nehalem_event_constraints[] =
>  
>  static struct extra_reg intel_nehalem_extra_regs[] =
>  {
> -       INTEL_EVENT_EXTRA_REG(0xb7, 0x1a6, 0xffff, 32), /* OFFCORE_RESPONSE */
> +       /* OFFCORE_RESPONSE */
> +       INTEL_EVENT_EXTRA_REG(0xb7, MSR_OFFCORE_RSP_0, 0xffff, 32),
>         EVENT_EXTRA_END
>  }; 

Since we're going for another posting anyway, I think you can drop that
comment here, it should be evident from the MSR name included in the
constraint.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/