Re: declare MODULE_FIRMWARE in libsas

[AmÃrico Wang]

On Wed, Jan 05, 2011 at 01:28:26PM +0800, DuanZhenzhong wrote:
>AmÃrico Wang åé:
>>On Wed, Jan 05, 2011 at 11:18:45AM +0800, DuanZhenzhong wrote:
>>>Jeff Garzik åé:
>>>>On 01/04/2011 09:08 AM, James Bottomley wrote:
>>>>>On Tue, 2011-01-04 at 15:43 +0800, DuanZhenzhong wrote:
>>>>>>Signed-off-by: Zhenzhong Duan<zhenzhong.duan@xxxxxxxxxx>
>>>>>>
>>>>>>---
>>>>>Description?  Since libsas has no firmware, surely some explanation is
>>>>>required.
>>>>Indeed.  Looks bogus at first glance?
>>>>
>>>>
>>>I was finding all requested but not exported firmware in scsi driver
>>>for generating dump initrd use.
>>>In sas_scsi_host.c, request_firmware is called with "sas_addr",
>>>sas_addr neither builtin nor exported. Don't sas_addr a firmware?
>>>Please correct me. thanks
>>>
>>
>>But once you export it, it needs to be found in fireware/ directory...
>Not exactly, firmware/ dir only have a subset of all needed firmware.
>Also one can load firmware manually from anywhere
>

Then it should not be exported, otherwise user-space will get confused.
We have a script to parse modinfo output to get the firmwares of a module.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/