Re: [alsa-devel] [PATCH v3 2/3] ECI: introducing ECI bus driver

[Peter Ujfalusi]

Hi,

On 01/04/11 16:02, ext tapio.vihuri@xxxxxxxxx wrote:
> From: Tapio Vihuri <tapio.vihuri@xxxxxxxxx>
> 
> ECI bus controller is kind of bridge between host CPU I2C and ECI accessory
> ECI communication.

There seams to be no change between v2 and v3 in regards to this micro
controller driver, so my comments on the v2 applies here as well.

Would you rename the driver (to something other than ecibus)?
If the intention is to make this driver only work on Intel's Moorestown
platform, then be it, but you should mention it explicitly in the
Kconfig, and the driver name shall reflect the same as well.

My comments on the intel specific intel_scu_ipc_iowrite8, and the i2c
part still holds.

Thanks,
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/