Re: [RFC][PATCH 05/18] sched: Provide p->on_rq

[Peter Zijlstra]

On Wed, 2011-01-05 at 16:13 +0800, Yong Zhang wrote:
> > +       if (p->on_rq && p->rt.nr_cpus_allowed > 1)
> 
> How about on_rt_rq(&p->rt) here?
> 
> Quoted from my previous reply:
> [Seems we need on_rt_rq(&p->rt) here, otherwise we enqueue the
> task to pushable list when called from rt_mutex_setprio()/
> __sched_setscheduler() etc. Thus add a little overhead.
> Though we call dequeue_pushable_task() in set_curr_task_rt()
> unconditionally.] 

Ah, sorry for loosing that reply..

Yes I think that would work, Steven?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/