ia64 build broken [was: mmotm 2010-12-23-16-58 uploaded]

From: Jiri Slaby
Date: Thu Jan 06 2011 - 03:27:17 EST


On 01/04/2011 05:49 PM, Jiri Slaby wrote:
> 16dc39c98a6ca56a27f22f7ac6731d8223237a2e is first bad commit
> commit 16dc39c98a6ca56a27f22f7ac6731d8223237a2e
> Author: Len Brown <len.brown@xxxxxxxxx>
> Date: Thu Dec 16 23:12:23 2010 -0500
>
> ACPI: use ioremap_cache()
>
> Although the temporary boot-time ACPI table mappings
> were set up with CPU caching enabled, the permanent table
> mappings and AML run-time region memory accesses were
> set up with ioremap(), which on x86 is a synonym for
> ioremap_nocache().
>
> Changing this to ioremap_cache() improves performance as
> seen when accessing the tables via acpidump,
> or /sys/firmware/acpi/tables. It should also improve
> AML run-time performance.
>
> No change on ia64.

BTW I've just noted, you actually broke ia64. The code reads like:
return ioremap(unsigned long phys_addr, unsigned long size);

regards,
--
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/