Re: [PATCH] RS485 on Cris: use global value of TIOCSRS485

[Claudio Scordino]

Il 06/01/2011 14:34, Alan Cox ha scritto:
> > With this patch, TIOCSRS485 gets the same value across all
> > architectures, making maintenance and portability of user-level code
> > easier.
>
> I don't see why this is worth doing - no application code should ever
> hardcode the value.

I'm afraid this is true only in a theoretical world. But I hope I'm
wrong.

Actually, I can't see any reason to keep different values of TIOCSRS485
in the kernel code when we can have a single value across all
architectures.

But I trust your judgment: if you say it's not worth doing, let's
avoid it.

Many thanks,

	Claudio
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/