Re: [PATCH v2] input: tegra-kbc - Add tegra keyboard driver

[Randy Dunlap]

On Thu, 6 Jan 2011 23:15:01 +0100 (CET) Jesper Juhl wrote:

> > +fail:
> > +	if (kbc->irq >= 0)
> > +		free_irq(kbc->irq, pdev);
> > +	if (kbc->idev)
> > +		input_free_device(kbc->idev);
> 
> As far as I can tell input_free_device() deals gracefully with being 
> passed a null pointer, so the 'if' seems superfluous.
> 
> 
> -- 
> Jesper Juhl <jj@xxxxxxxxxxxxx>            http://www.chaosbits.net/
> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
> Plain text mails only, please.
+ Please trim replies to the relevant part(s) of patches.


thnx,
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/