Re: [PATCH 22/36] serial: fix pch_uart kconfig & build

[Greg KH]

On Fri, Jan 07, 2011 at 09:21:43AM +0900, Tomoya MORINAGA wrote:
> Hi Greg,
> 
> On Friday, January 07, 2011 7:23 AM, Greg Kroah-Hartman wrote:
> > Also, the help text says that the 
> > driver enables & uses PCH_DMA, which is not enabled, so select that. 
> 
> I think PCH_DMA is not always used when a user uses PCH_UART.
> Since overhead of DMA is not small, in case of low frequent communication,
> without DMA is better.
> Thus, I think "select PCH_DMA" is unnecessary
> 
> (Of course, the PCH_UART works both with/without PCH_DMA.)

Patches are always welcome to fix things up :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/