Re: [PATCH] perf: fix buffer overflow error caused by specifyingall tracepoints with -e option

[Pingtian Han]

My mistake, it should be 'patch' other than 'comments'. Thanks!

----- Original Message -----
From: "Arnaldo Carvalho de Melo" <acme@xxxxxxxxxxxxx>
To: "Han Pingtian" <phan@xxxxxxxxxx>
Cc: linux-kernel@xxxxxxxxxxxxxxx
Sent: Friday, January 7, 2011 2:30:12 AM
Subject: Re: [PATCH] perf: fix buffer overflow error caused by specifying	all tracepoints with -e option

Em Thu, Jan 06, 2011 at 05:39:22PM +0800, Han Pingtian escreveu:
> I found when specifying all tracepoints with -e to one of subcommand,
> such as 'top', the program will trigger a buffer overflow error, like
> this:
> 
> *** buffer overflow detected ***: ./perf terminated
> ======= Backtrace: =========
<SNIP>
> ....
> The tracepoints are separated by comma, something like this:
> 
> perf top -e ...,kmem:kmalloc,kmem:kfree,kmem:kmem_cache_free,...
> 
> This comment will fix this problem.
> 
> The root reason of this problem is that store_event_type() is called
> with all the events, and will overflow the 'filename' at
> 
>     strncat(filename, orgname, strlen(orgname));
> 
> The comments will try to call store_event_type() when the event name has
> been found out.

s/comments/patch/g, right? Other than that looks fine, applying.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/