Re: [PATCHv1 11/12] unicore32 core architecture: signals

[Arnd Bergmann]

On Saturday 25 December 2010, Guan Xuetao wrote:
> From: Guan Xuetao <guanxuetao@xxxxxxxxxxxxxxx>
> 
> Patch 11 implements signals.
> 
> Signed-off-by: Guan Xuetao <guanxuetao@xxxxxxxxxxxxxxx>
> ---
>  arch/unicore32/include/asm/sigcontext.h |   61 ++++
>  arch/unicore32/kernel/signal.c          |  571 +++++++++++++++++++++++++++++++
>  arch/unicore32/kernel/signal.h          |   16 +
>  3 files changed, 648 insertions(+), 0 deletions(-)

Al Viro recently did a major cleanup of the signal handling code in a
number of architectures. He can probably give much better feedback
on this one than I can.

The one thing that sticks out to me is that you implement both legacy
and rt signals, where new architectures should generally only need the
rt variant.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/