Re: [PATCH 2/2] Replace the dangerous to_root_device macro with an inline function

[Ferenc Wagner]

Greg KH <gregkh@xxxxxxx> writes:

> On Thu, Jan 06, 2011 at 09:47:08PM +0100, Ferenc Wagner wrote:
>
>> Greg KH <gregkh@xxxxxxx> writes:
>> 
>>> On Thu, Jan 06, 2011 at 04:24:24PM +0100, Ferenc Wagner wrote:
>>>
>>>> The original macro worked only when applied to variables named 'dev'.
>>>> While this could have been fixed by simply renaming the macro argument,
>>>> a more type-safe replacement is preferred.
>>>
>>> Preferred for what?  This is a local macro, not exported to anything
>>> else, is it causing problems today within this single file?
>> 
>> No, it isn't a problem currently, because this macro is applied to
>> variables named 'dev' exclusively.  But the macro definition is wrong,
>> as it uses 'dev' (the macro argument) in two places, of which the second
>> probably isn't intentional, as the third argument of the container_of
>> macro is a structure member name, which should stay fixed to the literal
>> string 'dev' in this case, not replaced by the actual macro argument.
>
> No, it was intentional :)

Then we should fix it's misleading name. :)

> I'll take this as a general "clean up" patch

Great, that's exactly what it is.

> if you resend it with the 2/2 removed.

On its way...

> But note that it will not get added to my trees until after the
> .38-rc1 merge happens.

No problem, it's been sitting in my tree for almost a year now. :)
-- 
Thanks,
Feri.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/