Re: [PATCH v4] net: add Faraday FTMAC100 10/100 Ethernet driver

[Po-Yu Chuang]

Dear Eric,

On Fri, Jan 21, 2011 at 5:08 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Le vendredi 21 janvier 2011 Ã 15:55 +0800, Po-Yu Chuang a Ãcrit :
> ...
>> +
>> + Â Â dma_unmap_single(priv->dev, map, skb_headlen(skb), DMA_TO_DEVICE);
>> +
>> + Â Â dev_kfree_skb_irq(skb);
>> +
>> + Â Â ftmac100_txdes_reset(txdes);
>> +
>> + Â Â ftmac100_tx_clean_pointer_advance(priv);
>> +
>> + Â Â priv->tx_pending--;
>> + Â Â netif_wake_queue(netdev);
>> +
>> + Â Â return true;
>> +}
>> +
>
> Thanks to NAPI, you can free skb directly, not queuing it via
> NET_TX_SOFTIRQ softirq, using dev_kfree_skb() instead of
> dev_kfree_skb_irq()

Fixed. Thanks a lot.

best regards,
Po-Yu Chuang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/