Re: [PATCH] parport: make lockdep happy with waitlist_lock

[Ingo Molnar]

* Alexander Gordeev <lasaine@xxxxxxxxxxxxx> wrote:

> parport_unregister_device should never be used when interrupts are
> enabled in hardware and irq handler is registered so there is no need
> to disable interrupts when using waitlist_lock. But there is no way to
> explain this subtle semantics to lockdep analyzer. So disable interrupts
> here too to simplify things. The price is negligible.
> 
> Signed-off-by: Alexander Gordeev <lasaine@xxxxxxxxxxxxx>
> ---
>  drivers/parport/share.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/parport/share.c b/drivers/parport/share.c
> index a2d9d1e..c3dd1a3 100644
> --- a/drivers/parport/share.c
> +++ b/drivers/parport/share.c
> @@ -678,7 +678,7 @@ void parport_unregister_device(struct pardevice *dev)
>  
>  	/* Make sure we haven't left any pointers around in the wait
>  	 * list. */
> -	spin_lock (&port->waitlist_lock);
> +	spin_lock_irq (&port->waitlist_lock);

Small detail: please use a consistent coding style, i.e. 'spin_lock_irq(', not 
'spin_lock_irq ('.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/