Re: [PATCH] xen-pcifront: don't use flush_scheduled_work()

[Konrad Rzeszutek Wilk]

On Mon, Jan 24, 2011 at 03:43:03PM +0100, Tejun Heo wrote:
> flush_scheduled_work() is scheduled for deprecation.  Cancel ->op_work

2.6.39 or 2.6.40? Not seeing it referenced in feature-removal-schedule.txt file?

> directly instead.
> 
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Ryan Wilson <hap9@xxxxxxxxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Cc: Jan Beulich <JBeulich@xxxxxxxxxx>
> Cc: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>
> ---
>  drivers/pci/xen-pcifront.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> Index: work/drivers/pci/xen-pcifront.c
> ===================================================================
> --- work.orig/drivers/pci/xen-pcifront.c
> +++ work/drivers/pci/xen-pcifront.c
> @@ -733,8 +733,7 @@ static void free_pdev(struct pcifront_de
>  
>  	pcifront_free_roots(pdev);
>  
> -	/*For PCIE_AER error handling job*/

Any reason for getting rid of the comment?

> -	flush_scheduled_work();
> +	cancel_work_sync(&pdev->op_work);
>  
>  	if (pdev->irq >= 0)
>  		unbind_from_irqhandler(pdev->irq, pdev);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/