Re: [PATCH 10/10] fs: make aio plug

[Jeff Moyer]

Jens Axboe <jaxboe@xxxxxxxxxxxx> writes:

>>> @@ -1698,6 +1701,7 @@ long do_io_submit(aio_context_t ctx_id, long nr,
>>>  		if (ret)
>>>  			break;
>>>  	}
>>> +	blk_finish_plug(&plug);
>>>  	aio_batch_free(batch_hash);
>> 
>> I'm pretty sure you want blk_finish_plug to run after aio_batch_free.
>
> You mean to cover the iput()? That's not a bad idea, if that ends up
> writing it out. I did a few read tests here and confirmed it's sending
> down batches of whatever number is submitted.

No, I actually didn't make it all the way through 5/10, so I didn't
realize you got rid of the blk_run_address_space.  I agree with the TODO
item to get rid of the aio batching, since it's now taken care of with
the on-stack plugging.

As for the iput, I don't think you will get the final iput here, since
you've just scheduled I/O against the file.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/