Re: [PATCH] get_maintainer.pl: Add support to match arbitrary text

[L. Alberto Giménez]

On Mon, Jan 24, 2011 at 03:53:46PM -0800, Joe Perches wrote:
> On Tue, 2011-01-25 at 00:32 +0100, L. Alberto Giménez wrote:
> > Extend the usage of the K section in the MAINTAINERS file to support matching
> > regular expressions with the content that precedes the patch (delimited by three
> > dashes "---").
> > +		} elsif (not $in_patch and m/^---/) {
> > +			# enter "patch area": keywords matched only on changed lines
> > +			$in_patch = 1;
> 
> Not all patches need or have ---
> 
> This would be better as "^---$"

Hi Joe,

As I replied to you previously, please feel free to fix the patch. Most of the
patches I've seen use that line as a separator. Could you please give me the
right regexp to detect the beginning of patches?

On the other hand, if it's not properly detected, it will just match the "K"
keywords against all the patch lines (not just deleted or added lines). For a
standard unified diff format that would be 3 context lines that should match
with something like "^Subject: whatever". Again, it's just a proposal waiting
for comments/enhancements.

The idea here was to enable "triggers" in the subject to add the proper CCs. It
just ended up in a "match anything against the file content" change.

Regards,
-- 
L. Alberto Giménez
JabberID agimenez@xxxxxxxxxxxxxxxxxx
GnuPG key ID 0x3BAABDE1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/