Re: [PATCH v5] net: add Faraday FTMAC100 10/100 Ethernet driver

[Po-Yu Chuang]

Dear Eric,

On Mon, Jan 24, 2011 at 11:07 PM, Eric Dumazet <eric.dumazet@xxxxxxxxx> wrote:
> Le lundi 24 janvier 2011 Ã 20:39 +0800, Po-Yu Chuang a Ãcrit :
>> From: Po-Yu Chuang <ratbert@xxxxxxxxxxxxxxxx>
>> +
>> + Â Â priv->tx_pending++;
>> + Â Â if (priv->tx_pending == TX_QUEUE_ENTRIES) {
>> + Â Â Â Â Â Â if (net_ratelimit())
>> + Â Â Â Â Â Â Â Â Â Â netdev_info(netdev, "tx queue full\n");
>
> Hmm, I guess you didnt tested your driver with a pktgen flood ;)
>
> This 'netdev_info(netdev, "tx queue full\n");' is not necessary, since
> its a pretty normal condition for a driver (to fill its TX ring buffer)

Errr... No, I didn't test it with pktgen. I tested it with normal NFS usages.
I'll try it.

best regards,
Po-Yu Chuang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/