Re: [PATCH] UBI: fix unaligned leb_start value

From: Artem Bityutskiy
Date: Tue Jan 25 2011 - 05:43:21 EST


On Fri, 2011-01-21 at 15:39 +0100, John Ogness wrote:
> From: John Ogness <john.ogness@xxxxxxxxxxxxx>
>
> The wrong header size was used in calculating the data offset. The
> data offset should be VID header offset + VID header size (aligned to
> the minimum I/O unit).
>
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

I've tweaked the commit message and pushed this to the UBI tree, thanks:
http://git.infradead.org/ubi-2.6.git/commit/a25376636fa6cee8017a22144652f276840281bf

> ---
> This patch is against linux-next-20110121.
>
> Since the value is later aligned, this patch does not fix any real
> world problem. But it should be fixed nonetheless.

Not exactly, this does not fix any real problem because UBI_EC_HDR_SIZE
and UBI_VID_HDR_SIZE are currently equivalent :-)

Thank you!

--
Best Regards,
Artem Bityutskiy (ÐÑÑÑÐ ÐÐÑÑÑÐÐÐ)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/