Re: [RFC] [PATCH 2.6.37-rc5-tip 8/20] 8: uprobes: mmap and forkhooks.

[Peter Zijlstra]

On Thu, 2010-12-16 at 15:28 +0530, Srikar Dronamraju wrote:
> +static void search_within_subtree(struct rb_node *n, struct inode *inode,
> +               struct list_head *tmp_list);
> +
> +static void add_to_temp_list(struct vm_area_struct *vma, struct inode *inode,
> +               struct list_head *tmp_list)
> +{
> +       struct uprobe *uprobe;
> +       struct rb_node *n;
> +       unsigned long flags;
> +
> +       n = uprobes_tree.rb_node;
> +       spin_lock_irqsave(&treelock, flags);
> +       while (n) {
> +               uprobe = rb_entry(n, struct uprobe, rb_node);
> +               if (match_inode(uprobe, inode, &n)) {
> +                       list_add(&uprobe->pending_list, tmp_list);
> +                       search_within_subtree(n, inode, tmp_list);
> +                       break;
> +               }
> +       }
> +       spin_unlock_irqrestore(&treelock, flags);
> +}
> +
> +static void __search_within_subtree(struct rb_node *p, struct inode *inode,
> +               struct list_head *tmp_list)
> +{
> +       struct uprobe *uprobe;
> +
> +       uprobe = rb_entry(p, struct uprobe, rb_node);
> +       if (match_inode(uprobe, inode, &p)) {
> +               list_add(&uprobe->pending_list, tmp_list);
> +               search_within_subtree(p, inode, tmp_list);
> +       }
> +
> +
> +}
> +
> +static void search_within_subtree(struct rb_node *n, struct inode *inode,
> +               struct list_head *tmp_list)
> +{
> +       struct rb_node *p;
> +
> +       if (p)
> +               __search_within_subtree(p, inode, tmp_list);
> +
> +       p = n->rb_right;
> +       if (p)
> +               __search_within_subtree(p, inode, tmp_list);
> +} 

Whee recursion FTW!, you just blew your kernel stack :-)

Since you sort inode first, offset second, I think you can simply look
for the first matching inode entry and simply rb_next() until you don't
match.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/