Re: [PATCH 0/0] Panic on softdog timeout

[Anithra P Janakiraman]

On 01/18/2011 10:05 PM, Dave Hansen wrote:
> On Tue, 2011-01-18 at 18:14 +0530, Anithra P Janakiraman wrote:
>    
> > We currently have no way of determining the reason for failure when a
> > softdog timeout occurs. At the minimum a snapshot of the system would
> > help to determine the cause.
> > The attached patch invokes panic on softdog timeout iff kdump is
> > configured, if kdump is not configured it works as usual.
> >      
> This sounds like a decent idea.  But, is it something that should be a
> bit more optional?  We currently have boot options for when to reboot or
> panic for other things, and this is really the first use of
> kexec_crash_image outside of kexec itself.  Is it really the best switch
> to use?
>
> Will this break anyone who expects a quick, clean, reboot and instead
> gets a kdump?  Should we make _all_ emergency_restart()s use kdump?
>
> You might have noticed, but your subject is a little wonky.  It should
> probably just omit the 1/1 stuff when you only have a single patch
> series.  The subject is pretty short and doesn't really explain what's
> going on.  Could you beef it up a bit?
>
>    

Thanks for looking at it and for the comments. I've sent a
version 2 of the patch that hopefully addresses all your
comments.

link:
http://permalink.gmane.org/gmane.linux.kernel/1091282

For some strange reason i'm unable to find a link to my
mail on lkml.org. I see emails only upto the 23rd of Jan.

Regards,
Anithra.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/