Re: [PATCH v1 1/6] Add oops notification chain.

From: Mike Waychison
Date: Tue Jan 25 2011 - 15:02:04 EST


On Mon, Jan 24, 2011 at 6:06 PM, Greg KH <greg@xxxxxxxxx> wrote:
> On Mon, Jan 24, 2011 at 04:24:39PM -0800, Mike Waychison wrote:
>> From: Aaron Durbin <adurbin@xxxxxxxxxx>
>>
>> Later firmware patches in this series would like to be able to be
>> notified whenever an oops occurs on the system, so that it can be
>> recorded in the boot log.
>>
>> This patch introduces a notifier_block called "oops_notifier_list"
>> so that drivers can register to get called whenever an Oops is
>> triggered.
>
> But we already have a panic notifier list.  Why create a new one?
> What's wrong with the existing one that doesn't work properly for you?

AFAICT, the panic notifier list doesn't get called on oops. Should we
reuse it and actually add meaning to the 'reason' argument? It does
become a misnomer if we do that :\
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/