Re: [PATCH 1/2] x86/platform: add a wallclock_init func tox86_platforms ops

[Feng Tang]

> Date: Tue, 25 Jan 2011 16:20:17 +0100 (CET)
> From: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> To: Alan Cox <alan@xxxxxxxxxxxxxxxxxxx>
> Cc: x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] x86/platform: add a wallclock_init func to
> x86_platforms ops
> 
> 
> On Tue, 25 Jan 2011, Alan Cox wrote:
> 
> > From: Feng Tang <feng.tang@xxxxxxxxx>
> > 
> > Some wall clock devices use MMIO based HW register, this new
> > function will give them a chance to do some initialization work
> > before their get/set_time service get called.
> > 
> > Signed-off-by: Feng Tang <feng.tang@xxxxxxxxx>
> > Signed-off-by: Jacob Pan <jacob.jun.pan@xxxxxxxxxxxxxxx>
> > Signed-off-by: Alan Cox <alan@xxxxxxxxxxxxxxx>
> > ---
> > 
> >  arch/x86/include/asm/x86_init.h |    2 ++
> >  arch/x86/kernel/setup.c         |    2 ++
> >  arch/x86/kernel/x86_init.c      |    2 ++
> >  3 files changed, 6 insertions(+), 0 deletions(-)
> > 
> > 
> > diff --git a/arch/x86/include/asm/x86_init.h
> > b/arch/x86/include/asm/x86_init.h index 64642ad..f7fa2e7 100644
> > --- a/arch/x86/include/asm/x86_init.h
> > +++ b/arch/x86/include/asm/x86_init.h
> > @@ -138,6 +138,7 @@ struct x86_cpuinit_ops {
> >  /**
> >   * struct x86_platform_ops - platform specific runtime functions
> >   * @calibrate_tsc:		calibrate TSC
> > + * @wallclock_init:		init the wallclock device
> 
> That's a one time called init function, so it should go into
> x86_init_ops.
> 
> Thanks,
> 
> 	tglx
> 

Hi Thomas,

Here is the updated one, if you think it's ok, I'll update the second patch later.

Thanks,
Feng
-------------