RE: [PATCH] firmware_classs: change val uevent's type to bool

[Berg, Johannes]

________________________________________
From: Bob Liu [lliubbo@xxxxxxxxx]
Sent: Wednesday, January 26, 2011 11:03
To: Berg, Johannes
Cc: linux-kernel@xxxxxxxxxxxxxxx; chrisw@xxxxxxxxxxxx; Winkler, Tomas; dmitry.torokhov@xxxxxxxxx; gregkh@xxxxxxx
Subject: Re: [PATCH] firmware_classs: change val uevent's type to bool

On Wed, Jan 26, 2011 at 5:56 PM, Berg, Johannes <johannes.berg@xxxxxxxxx> wrote:
> @@ -463,7 +463,8 @@ fw_create_instance(struct firmware *firmware, const char *fw_name,
>        f_dev->parent = device;
>        f_dev->class = &firmware_class;
>
> -       dev_set_uevent_suppress(f_dev, true);
> +       if (uevent)
> +               dev_set_uevent_suppress(f_dev, true);
>
> Everything but this is a no-op basically, but you didn't even describe this change?
>


Hmm.. Sorry for that, but I mentioned that by "fix a place missing
uevent check".
I added this check because I think it should be paired with following
dev_set_uevent_suppress(f_dev, false).

I don't think it should -- if you don't want uevents, then they should _always_ be suppressed, right?

johannes
--------------------------------------------------------------------------------------
Intel GmbH
Dornacher Strasse 1
85622 Feldkirchen/Muenchen, Deutschland 
Sitz der Gesellschaft: Feldkirchen bei Muenchen
Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
Registergericht: Muenchen HRB 47456 
Ust.-IdNr./VAT Registration No.: DE129385895
Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/