Re: [PATCH UPDATED 21/32] fs/aio: aio_wq isn't used in memory reclaim path

[Jeff Moyer]

Tejun Heo <tj@xxxxxxxxxx> writes:

> aio_wq isn't used during memory reclaim.  Convert to alloc_workqueue()
> without WQ_MEM_RECLAIM.  It's possible to use system_wq but given that
> the number of work items is determined from userland and the work item
> may block, enforcing strict concurrency limit would be a good idea.
>
> Also, move fput_work to system_wq so that aio_wq is used soley to
> throttle the max concurrency of aio work items and fput_work doesn't
> interact with other work items.
>
> Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Benjamin LaHaise <bcrl@xxxxxxxxx>
> Cc: Jeff Moyer <jmoyer@xxxxxxxxxx>

You actually missed that CC.  ;-)

> Cc: linux-aio@xxxxxxxxx
> ---
> Patch description updated to describe fput_work change.  If there's no
> further objection, I'll push it through workqueue#for-2.6.39.  Thanks.

Looks good to me, based on not changing existing semantics.

Acked-by: Jeff Moyer <jmoyer@xxxxxxxxxx>

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/