Re: [PATCH 7/7] zram: mark the disk as non-rotating media

[Robert Jennings]

* Robert Jennings (rcj@xxxxxxxxxxxxxxxxxx) wrote:
> * Dan Carpenter (error27@xxxxxxxxx) wrote:
> > On Wed, Jan 26, 2011 at 11:27:44AM -0600, Robert Jennings wrote:
> > > Adding QUEUE_FLAG_NONROT for the in the request_queue flags.  When used
> >                            ^^^^^^^^^^^^^^
> > "to the" perhaps?
> 
> Yeah, that was edited a few times and never re-read.  Thanks.
> 
> > > as a swap device, scan_swap_map will avoid the extra work of optimizing
> > > for rotating media.
> > > 
> > > Signed-off-by: Robert Jennings <rcj@xxxxxxxxxxxxxxxxxx>
> > > ---
> > >  drivers/staging/zram/zram_drv.c |    1 +
> > >  1 files changed, 1 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> > > index d5e0275..450c618 100644
> > > --- a/drivers/staging/zram/zram_drv.c
> > > +++ b/drivers/staging/zram/zram_drv.c
> > > @@ -593,6 +593,7 @@ static int create_device(struct zram *zram, int device_id)
> > >  		goto out;
> > >  	}
> > >  
> > > +	zram->queue->queue_flags ^= QUEUE_FLAG_NONROT;
> > 
> > QUEUE_FLAG_NONROT is 14.  We want to set the 14 bit.  This won't work.
> > 
> > Use queue_flag_set_unlocked(QUEUE_FLAG_NONROT, zram->queue);

I need to drop this patch entirely.  QUEUE_FLAG_NONROT is set in
zram_init_device and is unnecessary here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/