Re: [tip:sched/core] sched: Untangle cpu-load and timekeeping code

[Peter Zijlstra]

On Wed, 2011-01-26 at 20:29 +0800, Yong Zhang wrote:
> On Wed, Jan 26, 2011 at 12:14:43PM +0000, tip-bot for Peter Zijlstra wrote:
> > Commit-ID:  18a57c3b43781ea83c3bb21c3add84ba890d5fb3
> > Gitweb:     http://git.kernel.org/tip/18a57c3b43781ea83c3bb21c3add84ba890d5fb3
> > Author:     Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > AuthorDate: Tue, 25 Jan 2011 11:30:35 +0100
> > Committer:  Ingo Molnar <mingo@xxxxxxx>
> > CommitDate: Wed, 26 Jan 2011 12:33:23 +0100
> > 
> > sched: Untangle cpu-load and timekeeping code
> > 
> > Remove the calc_global_load() call from the timekeeping code and make
> > it local to the scheduler.
> > 
> > Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
> > LKML-Reference: <new-submission>
> > Signed-off-by: Ingo Molnar <mingo@xxxxxxx>
> > ---
> > +static void calc_global_load(unsigned long __data)
> >  {
> >  	long active;
> >  
> > -	calc_global_nohz(ticks);
> > +	calc_global_nohz();
> >  
> >  	if (time_before(jiffies, calc_load_update + 10))
> >  		return;
> 
> We should not do this checking any more. In normal case,
> it will always return false.
> If it indeed returns true for some reason, we will lose the
> timer forever.

Its needed for the nohz case, arguably we could move it inside
calc_global_nohz().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/