Re: [PATCH 1/3] When migrate_pages returns 0, all pages must havebeen released

[Minchan Kim]

On Thu, Jan 27, 2011 at 8:06 AM, Andrew Morton
<akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Fri, 21 Jan 2011 01:17:05 +0900
> Minchan Kim <minchan.kim@xxxxxxxxx> wrote:
>
>> From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
>>
>> From: Andrea Arcangeli <aarcange@xxxxxxxxxx>
>>
>> In some cases migrate_pages could return zero while still leaving a
>> few pages in the pagelist (and some caller wouldn't notice it has to
>> call putback_lru_pages after commit
>> cf608ac19c95804dc2df43b1f4f9e068aa9034ab).
>>
>> Add one missing putback_lru_pages not added by commit
>> cf608ac19c95804dc2df43b1f4f9e068aa9034ab.
>>
>> Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx>
>> Signed-off-by: Andrea Arcangeli <aarcange@xxxxxxxxxx>
>
> Some patch administrivia:
>
> a) you were on the delivery path for this patch, so you should have
>   added your signed-off-by:.  I have made that change to my copy.
>
>   There's no harm in also having a Reviewed-by:, but Signed-off-by:
>   does imply that, we hope.
>
> b) Andrea's From: line appeared twice.
>
> c) Please choose patch titles which identify the subsystem which is
>   being patched.  Plain old "mm:" will suit, although "mm:
>   compaction:" or "mm/compaction" would be nicer.
>
>   For some weird reason people keep on sending me patches with titles like
>
>        drivers: mmc: host: omap.c: frob the nozzle
>
>   or similar.  I think there might be some documentation file which
>   (mis)leads them to do this.  I simply do the utterly obvious and
>   convert it to
>
>        drivers/mmc/host/omap.c: frob the nozzle
>
>   duh.
>
> d) Please don't identify patches via bare commit IDs.  Because
>   commits can have different IDs in different trees.  Instead use the
>   form cf608ac19c95 ("mm: compaction: fix COMPACTPAGEFAILED
>   counting").  I end up having to do this operation multiple times a
>   day and it's dull.  And sometimes I don't even have that commit ID
>   in any of my trees, because they were working against some other
>   tree.
>
>   Also note that the 40-character commit ID has been trimmed to 12
>   characters or so.
>
> Thanks.
>

I should have read SubmittingPatches, again.
Thanks!!


-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/