Re: [PATCH] cgroup : remove the ns_cgroup

[Andrew Morton]

On Thu, 27 Jan 2011 09:08:51 +0800 Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> Andrew Morton wrote:
> > On Tue, 25 Jan 2011 10:39:48 +0100
> > Daniel Lezcano <daniel.lezcano@xxxxxxx> wrote:
> > 
> >> This patch removes the ns_cgroup as suggested in the following thread:
> > 
> > I had this patch queued up in September last year, but dropped it.  Why
> > did I do that?
> 
> Because you wanted to wait for some time for users (if any) to notice this
> coming change.
> 
> Author: Daniel Lezcano <daniel.lezcano@xxxxxxx>
> Date:   Wed Oct 27 15:33:38 2010 -0700
> 
>     cgroup: notify ns_cgroup deprecated
>     
>     The ns_cgroup will be removed very soon.  Let's warn, for this version,
>     ns_cgroup is deprecated.
>     
>     Make ns_cgroup and clone_children exclusive.  If the clone_children is set
>     and the ns_cgroup is mounted, let's fail with EINVAL when the ns_cgroup
>     subsys is created (a printk will help the user to understand why the
>     creation fails).
>     
>     Update the feature remove schedule file with the deprecated ns_cgroup.
>     
>     Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxx>
>     Acked-by: Paul Menage <menage@xxxxxxxxxx>
>     Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
>     Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>

ooh, that was clever of me.

Here is the text which was missing from the changelog:

  This is a userspace-visible change.  Commit 45531757b45c ("cgroup:
  notify ns_cgroup deprecated") (merged into 2.6.27) caused the kernel
  to emit a printk warning users that the feature is planned for
  removal.  Since that time we have heard from XXX users who were
  affected by this.

Please provide XXX.

How do we know that 2.6.37->2.6.38 is long enough?  Will any major
distros be released containing this warning in that timeframe?  I doubt
it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/