Re: [PATCH] printk: allow setting DEFAULT_MESSAGE_LEVEL via Kconfig

[WANG Cong]

On Wed, 26 Jan 2011 15:10:17 -0800, Andrew Morton wrote:

> On Wed, 26 Jan 2011 14:57:03 -0800
> Randy Dunlap <rdunlap@xxxxxxxxxxxx> wrote:
> 
>> > I'm a bit surprised that this wasn't already tunable at boot-time
>> > and/or at runtime.
>> 
>> 
>> As WANG Cong replied:
>> 
>> Why? We already have "loglevel=" kernel parameter.
> 
> That's different.
> 
> Mandeep's patch addresses printks which didn't have a facility level.
> Longer-term, all these should be fixed, so they have an explicit
> facility level.  I suppose that short-term it would make sense to prefer
> to blurt these messages onto the console rather than hiding them. 
> Because they might be important.  And if they weren't important, they
> will then irritate enough people to get themselves fixed.

Yeah, agreed. Actually checkpatch.pl will complain if a patch
contains a printk without KERN_*, this somewhat stops us having
more printk's without KERN_*.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/