Re: rwsem: rwsem: Remove redundant asmregparm annotation

From: David Howells
Date: Thu Jan 27 2011 - 10:04:25 EST


Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:

> Peter Zijlstra pointed out, that the only user of asmregparm (x86) is
> compiling the kernel already with -mregparm=3. So the annotation of
> the rwsem functions is redundant. Remove it.

That's fine - as long as we never remove the -mregparm=3 on i386. The inline
assembly relies on the regparm=3 calling convention.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/