Re: [PATCH v2 18/28] ARM: tegra: add CPU_IDLE driver

[Colin Cross]

On Thu, Jan 27, 2011 at 1:51 PM, Colin Cross <ccross@xxxxxxxxxxx> wrote:
> On Thu, Jan 27, 2011 at 12:38 PM, Stephen Boyd <sboyd@xxxxxxxxxxxxxx> wrote:
>> On 01/23/2011 06:01 PM, Colin Cross wrote:
>>>
>>> +static int __init tegra_cpuidle_debug_init(void)
>>> +{
>>> +     struct dentry *dir;
>>> +     struct dentry *d;
>>> +
>>> +     dir = debugfs_create_dir("cpuidle", NULL);
>>> +     if (!dir)
>>> +             return -ENOMEM;
>>> +
>>> +     d = debugfs_create_file("lp2", S_IRUGO, dir, NULL,
>>> +             &tegra_lp2_debug_ops);
>>> +     if (!d)
>>> +             return -ENOMEM;
>>> +
>>> +     return 0;
>>> +}
>>> +#endif
>>> +
>>> +late_initcall(tegra_cpuidle_debug_init);
>>
>> Will this compile with CONFIG_DEBUG_FS=n?
>
> Yes.  All debugfs ops return ERR_PTR(-ENODEV) if CONFIG_DEBUG_FS=n, so
> tegra_cpuidle_debug_init will do nothing and return 0.
>

Oops no, it will not compile.  Will fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/