RE: [PATCH v1] input: tegra-kbc: Fix build error.

From: Rakesh Iyer
Date: Fri Jan 28 2011 - 17:18:17 EST


No I think this slipped in, due to a last minute change to get the code < 80 lines.

Regards
Rakesh

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@xxxxxxxxx]
> Sent: Friday, January 28, 2011 2:10 PM
> To: Rakesh Iyer
> Cc: olof@xxxxxxxxx; Andrew Chew; linux-tegra@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; linux-input@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v1] input: tegra-kbc: Fix build error.
>
> On Fri, Jan 28, 2011 at 02:03:33PM -0800, riyer@xxxxxxxxxx wrote:
> > From: Rakesh Iyer <riyer@xxxxxxxxxx>
> >
> > Fix build error introduced by variable name change.
> >
>
> Did I manage to pick up wrong version?
>
> > Signed-off-by: Rakesh Iyer <riyer@xxxxxxxxxx>
> > ---
> > drivers/input/keyboard/tegra-kbc.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
> > index 6ca903a..ac471b7 100644
> > --- a/drivers/input/keyboard/tegra-kbc.c
> > +++ b/drivers/input/keyboard/tegra-kbc.c
> > @@ -355,8 +355,8 @@ static void tegra_kbc_config_pins(struct tegra_kbc *kbc)
> > for (i = 0; i < KBC_MAX_GPIO; i++) {
> > u32 r_shft = 5 * (i % 6);
> > u32 c_shft = 4 * (i % 8);
> > - u32 r_mask = 0x1f << r_shift;
> > - u32 c_mask = 0x0f << c_shift;
> > + u32 r_mask = 0x1f << r_shft;
> > + u32 c_mask = 0x0f << c_shft;
> > u32 r_offs = (i / 6) * 4 + KBC_ROW_CFG0_0;
> > u32 c_offs = (i / 8) * 4 + KBC_COL_CFG0_0;
> > u32 row_cfg = readl(kbc->mmio + r_offs);
> > --
> > 1.7.0.4
> >
>
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/