Re: [PATCH] radeon: Fix wrong boolean operator

[Alex Deucher]

On Fri, Jan 28, 2011 at 5:35 PM, Stefan Weil <weil@xxxxxxxxxxxxxxx> wrote:
> This error is reported by cppcheck:
> drivers/gpu/drm/radeon/radeon_encoders.c:1066: warning: Mutual exclusion over || always evaluates to true. Did you intend to use && instead?

Yes, should be &&.

Thanks,

Reviewed-by: Alex Deucher <alexdeucher@xxxxxxxxx>

>
> It looks like cppcheck is correct, so fix this. No test was run.
>
> Cc: David Airlie <airlied@xxxxxxxx>
> Cc: Alex Deucher <alexdeucher@xxxxxxxxx>
> Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Stefan Weil <weil@xxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/radeon/radeon_encoders.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_encoders.c b/drivers/gpu/drm/radeon/radeon_encoders.c
> index 5e90984..d4a5422 100644
> --- a/drivers/gpu/drm/radeon/radeon_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_encoders.c
> @@ -1063,7 +1063,7 @@ atombios_set_edp_panel_power(struct drm_connector *connector, int action)
>        if (!ASIC_IS_DCE4(rdev))
>                return;
>
> -       if ((action != ATOM_TRANSMITTER_ACTION_POWER_ON) ||
> +       if ((action != ATOM_TRANSMITTER_ACTION_POWER_ON) &&
>            (action != ATOM_TRANSMITTER_ACTION_POWER_OFF))
>                return;
>
> --
> 1.7.2.3
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/