Re: [PATCH 2/2] s390: Fix possibly wrong size in strncmp (smsglucv)

From: Stefan Weil
Date: Sat Jan 29 2011 - 18:01:08 EST


Am 29.01.2011 22:38, schrieb Jesper Juhl:
On Sat, 29 Jan 2011, Stefan Weil wrote:

This error was reported by cppcheck:
drivers/s390/net/smsgiucv.c:63: error: Using sizeof for array given as function argument returns the size of pointer.

Although there is no runtime problem as long as sizeof(u8 *) == 8,
this misleading code should get fixed.

Cc: Ursula Braun<ursula.braun@xxxxxxxxxx>
Cc: linux390@xxxxxxxxxx
Cc: Frank Blaschka<blaschka@xxxxxxxxxxxxxxxxxx>
Cc: Martin Schwidefsky<schwidefsky@xxxxxxxxxx>
Cc: Heiko Carstens<heiko.carstens@xxxxxxxxxx>
Cc: linux-s390@xxxxxxxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Signed-off-by: Stefan Weil<weil@xxxxxxxxxxxxxxx>
---
drivers/s390/net/smsgiucv.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/s390/net/smsgiucv.c b/drivers/s390/net/smsgiucv.c
index 65e1cf1..207b7d7 100644
--- a/drivers/s390/net/smsgiucv.c
+++ b/drivers/s390/net/smsgiucv.c
@@ -60,7 +60,7 @@ static struct iucv_handler smsg_handler = {
static int smsg_path_pending(struct iucv_path *path, u8 ipvmid[8],
u8 ipuser[16])
{
- if (strncmp(ipvmid, "*MSG ", sizeof(ipvmid)) != 0)
+ if (strncmp(ipvmid, "*MSG ", 8) != 0)
Hmm, shouldn't this really be ARRAY_SIZE(ipvmid) ??

I think that would be wrong, too (only in this special case where
an array is passed as a function parameter).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/