Re: [PATCH 2/2] RFC: selinux: sysctl: fix selinux labeling brokenby last patch

[Stephen Smalley]

On Mon, 2011-01-31 at 19:03 +0200, Lucian Adrian Grijincu wrote:
> On Mon, Jan 31, 2011 at 6:59 PM, Stephen Smalley <sds@xxxxxxxxxxxxx> wrote:
> > /proc/sys inode labeling was disabled earlier (hence marked S_PRIVATE)
> > when /proc/sys was reimplemented by Eric, so all access control
> > on /proc/sys was switched to using the sysctl hook rather than the
> > inode-based checking.  That's why you don't get a result from ls -Z
> > on /proc/sys on current kernels.  Getting actual labeling working again
> > for those inodes would be a win, so your patch is an improvement in that
> > regard for selinux.
> 
> 
> Oh, OK. Thanks for letting me know.
> 
> Do you see anything else that is wrong with these patches (apart from
> "//deleted")?

No, although I think someone should take them for a spin on a modern
Fedora in enforcing mode for a bit, and likely run the selinux testsuite
too.

-- 
Stephen Smalley
National Security Agency

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/