Re: [PATCH 4/4] pidns: Use task_active_pid_ns where appropriate
From: Daniel Lezcano
Date: Tue Feb 01 2011 - 05:07:18 EST
On 01/31/2011 04:36 PM, Oleg Nesterov wrote:
On 01/31, Daniel Lezcano wrote:
On 01/31/2011 12:26 PM, Alexey Dobriyan wrote:
This task_active_pid_ns() is misnamed(?) because it does matter only
for dead tasks?
Actually this function is later used, for the unshare, to get the pid_ns
of a specific task, not the current one.
Well, it is already used to get the pid_ns of !current task.
http://kerneltrap.org/mailarchive/linux-kernel/2010/6/20/4585095
The actual need for this change is that you are going to complicate
the things so that current->proxy->pid_ns != task_active_pid_ns().
This makes me cry ;)
Mmh, ok that makes sense.
Please don't forget, this patch is buggy, iirc...
Ok, I will resend the cleanup patchset without this patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/