Re: [leds-pca9532] Add gpio capability

[Wolfram Sang]

> > +static int pca9532_gpio_direction_output(struct gpio_chip *gc,
> > unsigned offset, int val)
> > +{
> > + return 0;
> > +}
> > +
> 
> Not good.  When the pin is configured as an output, the direction_output method also
> requests that the pin be set to a desired level.  For this driver that means that the
> pca9532_gpio_direction_output function just needs to call pca9532_gpio_set_value.

Ack, missed that. Thanks a lot!

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature