Re: [PATCH v2] altera_ps2: Add devicetree support

From: Thomas Chou
Date: Wed Feb 02 2011 - 18:32:12 EST


On 02/02/2011 11:38 PM, Grant Likely wrote:
On Wed, Feb 02, 2011 at 07:48:58PM +0800, Thomas Chou wrote:
On 02/02/2011 12:31 PM, Grant Likely wrote:
+static const struct of_device_id altera_ps2_match[] = {
+ { .compatible = "altr,ps2-1.0", },

I thought I had seen 'altera' instead of an abbreviation being used in
a previous patch. I don't care much whether 'altr' or 'altera' is
used, but I'd like to know that there is consensus from the Altera
users so that all the drivers use the same prefix.


We had discussed on nios2-dev mailing list, and decided to use
'altr' as Walter suggested that it saves space.

About the documentation on dts binding, shall we have a single
altera.txt to describe all Altera related binding, and opencores.txt
to describe all OpenCores binding? Or separate file for each core in
its driver class?

Since I'm reorganizing the binding documentation to reflect subsystems
(bindings/spi, bindings/i2c, bindings/powerpc, etc) I'd prefer to see
a separate file for each type of core.

OK. We will use separate files. I will send an updated patch to include the dts binding.

As for nios2 cpu related binding, we shall use binding/nios2 dir. Right?

- Thomas


Eventually, I'd like to define a record format for documenting
bindings that can generate searchable and crosslinked output, but I've
not spent any time looking at that seriously yet.

g.


- Thomas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/