Re: [EDAC-AMD64] Display correct RAM sizes in ganged mode on F10 CPUs

[Markus Trippelsdorf]

On 2011.02.03 at 16:17 +0100, Borislav Petkov wrote:
> On Tue, Feb 01, 2011 at 02:27:52PM -0500, Markus Trippelsdorf wrote:
> > On 2011.02.01 at 19:51 +0100, Borislav Petkov wrote:
> > > On Sat, Jan 29, 2011 at 04:15:31PM -0500, Markus Trippelsdorf wrote:
> > > > The EDAC_AMD64 module displays only half the actual memory size, when
> > > > RAM is running in ganged mode on F10 CPUs. Fix this by moving the the
> > > > conversion factor check out of the if block, where it is never reached.
> > > >
> > > > With this patch:
> > > >
> > > > Unganged:
> > > >  amd64: DRAM ECC enabled.
> > > >  EDAC amd64: F10h detected (node 0).
> > > >  EDAC amd64: using x4 syndromes.
> > > >  EDAC MC: DCT0 chip selects:
> > > >  kernel: EDAC amd64: MC: 0:  1024MB 1:  1024MB
> > > >  kernel: EDAC amd64: MC: 2:  1024MB 3:  1024MB
> > > >  kernel: EDAC amd64: MC: 4:     0MB 5:     0MB
> > > >  kernel: EDAC amd64: MC: 6:     0MB 7:     0MB
> > > >  kernel: EDAC MC: DCT1 chip selects:
> > > >  kernel: EDAC amd64: MC: 0:  1024MB 1:  1024MB
> > > >  kernel: EDAC amd64: MC: 2:  1024MB 3:  1024MB
> > > >  kernel: EDAC amd64: MC: 4:     0MB 5:     0MB
> > > >  kernel: EDAC amd64: MC: 6:     0MB 7:     0MB
> > > >  kernel: EDAC amd64: MCT channel count: 2
> 
> Ok, you've found a bug but it has to be fixed differently. See, the
> above reporting scheme actually doesn't change based on whether we're
> ganged or not. In your case, for example, you have 4 2GB dual-ranked
> DIMMs and they should always be shown as above, DCT0 has 2 DIMMs, with
> chip selects 0 and 1 (aka ranks) being DIMM0 and chip selects 2 and 3
> being DIMM2. You have the same config on the other channel, i.e. DCT1.
> 
> Now, when we're running ganged, you still have the same physical
> configuration with the only difference that we read from the two DCTs in
> parallel. Thus, we want to print the above structure independent from
> the ganged setting.
> 
> Here's a fix, it should correct the reporting on your machine.

Hm, that doesn't work:

EDAC amd64: F10h detected (node 0).
EDAC MC: DCT0 chip selects:
EDAC amd64: MC: 0:  1024MB 1:  1024MB
EDAC amd64: MC: 2:  1024MB 3:  1024MB
EDAC amd64: MC: 4:     0MB 5:     0MB
EDAC amd64: MC: 6:     0MB 7:     0MB
EDAC MC: DCT1 chip selects:
EDAC amd64: MC: 0:     0MB 1:     0MB
EDAC amd64: MC: 2:     0MB 3:     0MB
EDAC amd64: MC: 4:     0MB 5:     0MB
EDAC amd64: MC: 6:     0MB 7:     0MB
EDAC amd64: using x4 syndromes.

-- 
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/