Re: [PATCH 1/1] x86, apic: Make "broken BIOS!!" messages unique

[Ingo Molnar]

* H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> On 02/04/2011 09:48 AM, John Villalovos wrote:
> > x86, apic: Make "broken BIOS!!" messages unique
> > 
> > There are five identical "broken BIOS!!" messages.  This patch makes each
> > message unique so that it is easier to determine which message was actually
> > printed.
> > 
> > The 'inconceivable' messages are because it should not be possible to reach
> > those code paths.
> 
> How about labelling these "MPBIOS" or so, too?

Yeah.

Also, the messages do not need to shout i suspect - the '!!' can be removed as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/