Re: [PATCH] thermal: Use freezable workqueue

[Tejun Heo]

Hello, Dmitry, Rafael.

On Tue, Feb 08, 2011 at 10:20:25AM +0100, Rafael J. Wysocki wrote:
> > > +	thermal_wq = alloc_workqueue("thermal", WQ_FREEZEABLE, 0);
> > 
> > Should probably be unbound as well.
> 
> Yup, thanks.

Hmm.. why should it be unbound?  Unbound wqs are primarily useful for
very long running (system daemon type) works which may also consume
considerable amount of cpu cycles.

> > FWIW, I would not mind if we had a global freezeable workqueue already
> > predefined. I could switch input_polldev and vmw_balloon to it and there
> > probably could be more users...
> 
> Hmm, OK.
> 
> Do you think we should add system_freezeable_wq to the set of predefined
> workqueues?

Oh, yeah, definitely.  I'll write up a patch.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/