Re: [PATCH 00/14] POWER: BQ27x00: New Properties, fixes, bq27000 support

[Grazvydas Ignotas]

On Mon, Feb 7, 2011 at 3:30 AM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
> On 02/07/2011 01:58 AM, Grazvydas Ignotas wrote:
>> On Sun, Feb 6, 2011 at 2:47 AM, Lars-Peter Clausen <lars@xxxxxxxxxx> wrote:
>>> This series has so far been tested with the bq27000 and the bq27200 battery, but
>>> not with the bq27500 battery, so it would be nice if somebody with a board
>>> containing such a battery could test the patches to make sure that there are no
>>> regressions.
>>
>> Trying this on pandora board (bq27500 over i2c) and it seems there is
>> something wrong with the cache, I'm always getting the old values. I'm
>> reading them manually over sysfs, uptime is over 25min but values
>> still match ones on boot, even after turning off the backlight.
>>
>> Looking at the code delayed_work handling looks suspicious,
>> bq27x00_battery_get_property() flushes it and nothing ever reschedules
>> it. Other than that all new property values looks sane.
>
> Hi
>
> Hm, I tought that rescheduling from withing the work function would work, even when
> flushing the work, at least it did here.
> But the current code is broken if poll_interval is 0 anyway, cause then it wont
> reschedule itself and is never run again.
>
> Could you try:
>
> if (time_is_before_jiffies(di->last_update + 6 * HZ)) {
>        cancel_delayed_work_sync(&di->work);
>        bq27x00_battery_work(&di->work);
> }

That works. However I wonder about the delay, I've experimentally
determined that bq27500 refreshes in about a second, so before this
series I could for example run 'watch -n 1 cat current_now' and see
current changes almost in realtime (when toggling backlight, for
example). Maybe we could have different cache timeout for different
chips or have quickly changing properties (like current and voltage)
bypass the cache.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/