Re: [PATCH] HID: added new driver for Panasonic Elite PanaboardUB-T780 and UB-T880
From: Dmitry Torokhov
Date: Tue Feb 08 2011 - 13:12:51 EST
On Tue, Feb 08, 2011 at 11:39:23AM +0100, Henrik Rydberg wrote:
>
> > +int xold = 0, yold = 0;
>
> static
>
Not even that. This is an USB device, not a platform one, so it shoudl
be opssible to connect more than one to a box. All state should go into
per-device structure.
This is also does not appear to be a HID driver, really - it does not
use HID infrastucture but does custom parsing.
Calibration - normally we offload this task to userspace (tslib
or other library/driver).
Thanks.
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/