Re: [PATCH V2 2/3] drivers/staging: zcache: host services and PAM services

From: Minchan Kim
Date: Tue Feb 08 2011 - 17:48:26 EST


On Mon, Feb 7, 2011 at 12:26 PM, Dan Magenheimer
<dan.magenheimer@xxxxxxxxxx> wrote:
> [PATCH V2 2/3] drivers/staging: zcache: host services and PAM services
>
> Zcache provides host services (memory allocation) for tmem,
> a "shim" to interface cleancache and frontswap to tmem, and
> two different page-addressable memory implemenations using
> lzo1x compression. ÂThe first, "compression buddies" ("zbud")
> compresses pairs of pages and supplies a shrinker interface
> that allows entire pages to be reclaimed. ÂThe second is
> a shim to xvMalloc which is more space-efficient but
> less receptive to page reclamation. ÂThe first is used
> for ephemeral pools and the second for persistent pools.
> All ephemeral pools share the same memory, that is, even
> pages from different pools can share the same page.
>
> Signed-off-by: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
> Signed-off-by: Nitin Gupta <ngupta@xxxxxxxxxx>

Hi Dan,
First of all, thanks for endless effort.

I didn't look at code entirely but it seems this series includes frontswap.
Finally frontswap is to replace zram?

If it is right, how about approaching one by one for easy review and merging?
I mean firstly we replace zram into frontswap and tmem and then zcache.
Regardless of my suggestion, I will look at the this series in my spare time.

--
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/