Re: [RFC][PATCH 2/4] ftrace: Add -mfentry to Makefile on functiontracer
From: H. Peter Anvin
Date: Wed Feb 09 2011 - 16:23:13 EST
On 02/09/2011 12:28 PM, Steven Rostedt wrote:
> On Wed, 2011-02-09 at 15:02 -0500, Steven Rostedt wrote:
>
>> ifdef CONFIG_FUNCTION_TRACER
>> -KBUILD_CFLAGS += -pg
>> +ifdef CONFIG_HAVE_FENTRY
>> +CC_HAS_FENTRY := $(call cc-option, -mfentry -DCC_HAS_FENTRY)
>
> I should include a thanks to H. Peter Anvin in the change log for
> telling me about the cc-option trick.
>
Actually we should probably calling this -DCC_USING_FENTRY or something
like that, since as coded above it includes the CONFIG_FUNCTION_TRACER
dependency. This is a good thing -- it makes the conditionals easier --
we just also want to make sure they don't get misunderstood.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/