Re: [PATCH] mm: Fix out-of-date comments which refers non-existent functions

[Minchan Kim]

On Thu, Feb 10, 2011 at 12:58 PM, Ryota Ozaki <ozaki.ryota@xxxxxxxxx> wrote:
> On Thu, Feb 10, 2011 at 8:58 AM, KAMEZAWA Hiroyuki
> <kamezawa.hiroyu@xxxxxxxxxxxxxx> wrote:
>> On Wed, Â9 Feb 2011 23:42:17 +0900
>> Ryota Ozaki <ozaki.ryota@xxxxxxxxx> wrote:
>>
>>> From: Ryota Ozaki <ozaki.ryota@xxxxxxxxx>
>>>
>>> do_file_page and do_no_page don't exist anymore, but some comments
>>> still refers them. The patch fixes them by replacing them with
>>> existing ones.
>>>
>>> Signed-off-by: Ryota Ozaki <ozaki.ryota@xxxxxxxxx>
>>
>> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx>
>
> Thanks, Kamezawa-san.
>
>>
>> It seems there are other ones ;)
>> ==
>> Â ÂSearched full:do_no_page (Results 1 - 3 of 3) sorted by relevancy
>>
>> Â/linux-2.6-git/arch/alpha/include/asm/
>> H A D  cacheflush.h  Â66 /* This is used only in do_no_page and do_swap_page. */
>> Â/linux-2.6-git/arch/avr32/mm/
>> H A D  cache.c     116 * This one is called from do_no_page(), do_swap_page() and install_page().
>> Â/linux-2.6-git/mm/
>> H A D  memory.c    Â2121 * and do_anonymous_page and do_no_page can safely check later on).
>> 2319 * do_no_page is protected similarly.
>
> Nice catch :-) Cloud I assemble all fixes into one patch?
>
> Âozaki-r
>

When you resend the patch, Please Cc Jiri Kosina <trivial@xxxxxxxxxx>


-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/